linux-kernel - Re: [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a78e1fa4-3e13-466e-a0ae-04912e90c09a@kernel.org>
Date: Tue, 1 Oct 2024 21:45:27 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gax-c <zichenxie0106@...il.com>, srinivas.kandagatla@...aro.org,
 lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
 rohitkr@...eaurora.org
Cc: alsa-devel@...a-project.org, linux-arm-msm@...r.kernel.org,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org, Zijie Zhao <zzjas98@...il.com>,
 Chenyuan Yang <chenyuan0y@...il.com>
Subject: Re: [PATCH] ASoC: qcom: Fix NULL Dereference in
 asoc_qcom_lpass_cpu_platform_probe()

On 01/10/2024 02:24, Gax-c wrote:
> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could possibly return NULL pointer.
> NULL Pointer Dereference may be triggerred without addtional check.
> Add a NULL check for the returned pointer.
> 
> Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers")
> Signed-off-by: Zichen Xie <zichenxie0106@...il.com>
> Reported-by: Zichen Xie <zichenxie0106@...il.com>
> Reported-by: Zijie Zhao <zzjas98@...il.com>
> Reported-by: Chenyuan Yang <chenyuan0y@...il.com>

Commit still needs improvements.

You ignored also Bjorn's review.

Best regards,
Krzysztof