linux-kernel - Re: [PATCH 2/2] dt-bindings: mtd: davinci: add support for on-die ECC engine type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241001221032.525be1e4@xps-13>
Date: Tue, 1 Oct 2024 22:10:32 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Marcus Folkesson <marcus.folkesson@...il.com>
Cc: Richard Weinberger <richard@....at>, Vignesh Raghavendra
 <vigneshr@...com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: mtd: davinci: add support for on-die
 ECC engine type

Hi Marcus,

marcus.folkesson@...il.com wrote on Tue, 01 Oct 2024 12:42:27 +0200:

> Some chips, e.g. Micron MT29F1G08ABBFAH4, has a mandatory on-die ECC.
> Add "on-die" as ECC engine type in order to be compatible with those.
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
> ---
>  Documentation/devicetree/bindings/mtd/davinci-nand.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/davinci-nand.txt b/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> index eb8e2ff4dbd2901b3c396f2e66c1f590a32dcf67..9afda5cd956494c6b3171bdbaecaeb289acd64ea 100644
> --- a/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> @@ -44,6 +44,7 @@ Recommended properties :
>  				- "none"
>  				- "soft"
>  				- "hw"
> +				- "on-die"

This file is very legacy and this addition would be totally unneeded if
that file had been converted to yaml earlier. Just referencing
nand-controller.yaml will authorize nand-ecc-mode = "on-die" (while
still marking it legacy). Would you mind converting this file please?

Thanks,
Miquèl