linux-kernel - Re: [PATCH 2/2] dt-bindings: mtd: davinci: add support for on-die ECC engine type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zvz7GDA278Vam4nQ@gmail.com>
Date: Wed, 2 Oct 2024 09:49:44 +0200
From: Marcus Folkesson <marcus.folkesson@...il.com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Richard Weinberger <richard@....at>,
	Vignesh Raghavendra <vigneshr@...com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: mtd: davinci: add support for on-die
 ECC engine type

Hi Miquel,

On Tue, Oct 01, 2024 at 10:10:32PM +0200, Miquel Raynal wrote:
> Hi Marcus,
> 
> marcus.folkesson@...il.com wrote on Tue, 01 Oct 2024 12:42:27 +0200:
> 
> > Some chips, e.g. Micron MT29F1G08ABBFAH4, has a mandatory on-die ECC.
> > Add "on-die" as ECC engine type in order to be compatible with those.
> > 
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
> > ---
> >  Documentation/devicetree/bindings/mtd/davinci-nand.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mtd/davinci-nand.txt b/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> > index eb8e2ff4dbd2901b3c396f2e66c1f590a32dcf67..9afda5cd956494c6b3171bdbaecaeb289acd64ea 100644
> > --- a/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> > +++ b/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> > @@ -44,6 +44,7 @@ Recommended properties :
> >  				- "none"
> >  				- "soft"
> >  				- "hw"
> > +				- "on-die"
> 
> This file is very legacy and this addition would be totally unneeded if
> that file had been converted to yaml earlier. Just referencing
> nand-controller.yaml will authorize nand-ecc-mode = "on-die" (while
> still marking it legacy). Would you mind converting this file please?

Sure, I will give it a try.
I will send out a v2 later today.

> 
> Thanks,
> Miquèl


Best regards,
Marcus Folkesson

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)