linux-kernel - Re: [PATCH] spmi: pmic-arb: fix return path in for_each_available_child_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f61f1e1-6b41-4b1b-b00f-249901df320a@linaro.org>
Date: Tue, 1 Oct 2024 15:16:14 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Stephen Boyd <sboyd@...nel.org>, Abel Vesa <abel.vesa@...aro.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] spmi: pmic-arb: fix return path in
 for_each_available_child_of_node()

Le 01/10/2024 à 14:55, Javier Carrasco a écrit :
> This loop requires explicit calls to of_node_put() upon early exits
> (break, goto, return) to decrement the child refcounter and avoid memory
> leaks if the child is not required out of the loop.
> 
> A more robust solution is using the scoped variant of the macro, which
> automatically calls of_node_put() when the child goes out of scope.
> 
> Cc: stable@...r.kernel.org
> Fixes: 979987371739 ("spmi: pmic-arb: Add multi bus support")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
>   drivers/spmi/spmi-pmic-arb.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
> index 9ba9495fcc4b..ea843159b745 100644
> --- a/drivers/spmi/spmi-pmic-arb.c
> +++ b/drivers/spmi/spmi-pmic-arb.c
> @@ -1763,14 +1763,13 @@ static int spmi_pmic_arb_register_buses(struct spmi_pmic_arb *pmic_arb,
>   {
>   	struct device *dev = &pdev->dev;
>   	struct device_node *node = dev->of_node;
> -	struct device_node *child;
>   	int ret;
>   
>   	/* legacy mode doesn't provide child node for the bus */
>   	if (of_device_is_compatible(node, "qcom,spmi-pmic-arb"))
>   		return spmi_pmic_arb_bus_init(pdev, node, pmic_arb);
>   
> -	for_each_available_child_of_node(node, child) {
> +	for_each_available_child_of_node_scoped(node, child) {
>   		if (of_node_name_eq(child, "spmi")) {
>   			ret = spmi_pmic_arb_bus_init(pdev, child, pmic_arb);
>   			if (ret)
> 
> ---
> base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
> change-id: 20241001-spmi-pmic-arb-scoped-a4b90179edef
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>