linux-kernel - Re: [PATCH] ARM: dts nuvoton: Add EDAC node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ce7c039983bbc0c5bc1a1600a3613337cc45ae9.camel@codeconstruct.com.au>
Date: Wed, 02 Oct 2024 12:41:11 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: "William A. Kennington III" <william@...nnington.com>, Tomer Maimon
	 <tmaimon77@...il.com>, Rob Herring <robh@...nel.org>
Cc: devicetree@...r.kernel.org, openbmc@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org, "William A. Kennington III" <wak@...gle.com>
Subject: Re: [PATCH] ARM: dts nuvoton: Add EDAC node

Hi William,

As a bit of a nit, you missed the `:` after `dts` in the patch subject.

On Mon, 2024-09-30 at 14:46 -0700, William A. Kennington III wrote:
> From: "William A. Kennington III" <wak@...gle.com>
> 
> We have the driver support code, now we just need to expose the device
> node which can export the EDAC properties for the system memory
> controller. Tested on real hardware to verify that error counters show
> up.
> 
> Signed-off-by: William A. Kennington III <wak@...gle.com>
> ---
>  arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> index 5aeb5009a5d7..019abceb16a0 100644
> --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> @@ -127,6 +127,13 @@ clk: clock-controller@...01000 {
>  			clocks = <&clk_refclk>, <&clk_sysbypck>, <&clk_mcbypck>;
>  		};
>  
> +		mc: memory-controller@...24000 {
> +			compatible = "nuvoton,";

This compatible string doesn't look right to me. Are you sure?

Andrew