linux-kernel - Re: [PATCH] ARM: dts: nuvoton: Add OHCI node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65b8ae466fd2d285d3bf5c73c9a38ed6c73ef0a8.camel@codeconstruct.com.au>
Date: Wed, 02 Oct 2024 12:39:42 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: "William A. Kennington III" <william@...nnington.com>, Tomer Maimon
	 <tmaimon77@...il.com>, Rob Herring <robh@...nel.org>
Cc: devicetree@...r.kernel.org, openbmc@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org, "William A. Kennington III" <wak@...gle.com>
Subject: Re: [PATCH] ARM: dts: nuvoton: Add OHCI node

Hi William,

On Mon, 2024-09-30 at 14:43 -0700, William A. Kennington III wrote:
> From: "William A. Kennington III" <wak@...gle.com>
> 
> The EHCI peripheral already exists in the devicetree, but the hardware
> also supports a discrete OHCI unit on the same USB PHY. Generic OHCI
> works fine for this device already and has been tested on real hardware.
> 
> Signed-off-by: William A. Kennington III <wak@...gle.com>
> ---
>  arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> index 358b52894ac0..5aeb5009a5d7 100644
> --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
> @@ -142,6 +142,13 @@ gmac0: eth@...02000 {
>  			status = "disabled";
>  		};
>  
> +		ohci1: ohci@...07000 {

I got an additional warning here too:

+/home/andrew/src/kernel.org/linux/origin/build.multi_v5/arch/arm/boot/dts/nuvoton/nuvoton-npcm750-evb.dtb: ohci@...07000: $nodename:0: 'ohci@...07000' does not match '^usb(@.*)?'
+       from schema $id: http://devicetree.org/schemas/usb/generic-ohci.yaml#

Andrew

> +			compatible = "generic-ohci";
> +			reg = <0xf0807000 0x1000>;
> +			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
> +			status = "disabled";
> +		};
> +
>  		ehci1: usb@...06000 {
>  			compatible = "nuvoton,npcm750-ehci";
>  			reg = <0xf0806000 0x1000>;