linux-kernel - Re: [PATCH v2 0/7] qrb4210-rb2: add HDMI audio playback support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172784025903.526797.17199774017741034406.robh@kernel.org>
Date: Tue, 01 Oct 2024 22:52:09 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Alexey Klimov <alexey.klimov@...aro.org>
Cc: devicetree@...r.kernel.org, tiwai@...e.com, 
 linux-kernel@...r.kernel.org, alsa-devel@...a-project.org, 
 krzysztof.kozlowski@...aro.org, linux-arm-msm@...r.kernel.org, 
 lgirdwood@...il.com, srinivas.kandagatla@...aro.org, 
 konrad.dybcio@...aro.org, elder@...aro.org, dmitry.baryshkov@...aro.org, 
 conor+dt@...nel.org, andersson@...nel.org, broonie@...nel.org, 
 a39.skl@...il.com, krzk+dt@...nel.org, bgoswami@...cinc.com, 
 linux-sound@...r.kernel.org, perex@...ex.cz, caleb.connolly@...aro.org
Subject: Re: [PATCH v2 0/7] qrb4210-rb2: add HDMI audio playback support


On Wed, 02 Oct 2024 03:20:08 +0100, Alexey Klimov wrote:
> Rebased on top of -master, tested.
> 
> Changes since v1:
> -- removed handling of MI2S clock in sm2450_snd_shutdown(): setting clock rate
>    and disabling it causes audio delay on playback start;
> -- removed empty sound { } node from sm6115.dtsi as suggested by Krzysztof;
> -- moved lpi_i2s2_active pins description to qrb423310 board-specific file
>    as suggested by Dmitry Baryshkov;
> -- moved q6asmdai DAIs to apr soc node as suggested by Konrad Dybcio;
> -- lpass_tlmm is not disabled;
> -- lpass_tlmm node moved to sm4250.dtsi;
> -- kept MultiMedia DAIs as is, without them the sound card driver doesn't initialise;
> -- added some reviewed-by tags.
> 
> This series still keeps "qcom,qrb4210-rb2-sndcard" for sm8250 soundcard. As per
> off the list discussion with Srini it was suggested to have it since in future it
> may be required to add clocks, workarounds, quirks, model-specific things based on
> this compatible. The same as for RB5 compatible in sm8250 snd driver.
> 
> This focuses on HDMI audio playback only hence there are no soundwire and dmic pins,
> for instance. The work to enable playback via wcd+wsa8815 amplifier is in progress (it works)
> and one of the routes is to merge such two patchsets together.
> 
> Link to prev series:
> https://lore.kernel.org/linux-sound/20240628010715.438471-1-alexey.klimov@linaro.org/
> 
> Alexey Klimov (7):
>   ASoC: dt-bindings: qcom,sm8250: add qrb4210-rb2-sndcard
>   ASoC: qcom: sm8250: add qrb4210-rb2-sndcard compatible string
>   ASoC: qcom: sm8250: add handling of secondary MI2S clock
>   arm64: dts: qcom: sm6115: add apr and its services
>   arm64: dts: qcom: sm4250: add LPASS LPI pin controller
>   arm64: dts: qcom: qrb4210-rb2: add description of lpi_i2s2 pins
>   arm64: dts: qcom: qrb4210-rb2: add HDMI audio playback support
> 
>  .../bindings/sound/qcom,sm8250.yaml           |  1 +
>  arch/arm64/boot/dts/qcom/qrb4210-rb2.dts      | 91 +++++++++++++++++++
>  arch/arm64/boot/dts/qcom/sm4250.dtsi          | 16 ++++
>  arch/arm64/boot/dts/qcom/sm6115.dtsi          | 72 +++++++++++++++
>  sound/soc/qcom/sm8250.c                       |  9 ++
>  5 files changed, 189 insertions(+)
> 
> --
> 2.45.2
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/qrb4210-rb2.dtb' for 20241002022015.867031-1-alexey.klimov@...aro.org:

arch/arm64/boot/dts/qcom/qrb4210-rb2.dtb: pinctrl@...0000: lpi-i2s2-active-state: 'oneOf' conditional failed, one must be fixed:
	'pins' is a required property
	'function' is a required property
	Unevaluated properties are not allowed ('data-pins', 'ext-mclk1', 'sck-pin', 'ws-pins' were unexpected)
	'ext-mclk1', 'sck-pin' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sm4250-lpass-lpi-pinctrl.yaml#