linux-kernel - Re: [PATCH v2 6/7] arm64: dts: qcom: qrb4210-rb2: add description of lpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f460d95-3994-49df-a355-612d3d5c4c92@linaro.org>
Date: Wed, 2 Oct 2024 07:44:00 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Alexey Klimov <alexey.klimov@...aro.org>, linux-sound@...r.kernel.org,
 srinivas.kandagatla@...aro.org, bgoswami@...cinc.com, lgirdwood@...il.com,
 broonie@...nel.org
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 andersson@...nel.org, konrad.dybcio@...aro.org, perex@...ex.cz,
 tiwai@...e.com, linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
 devicetree@...r.kernel.org, elder@...aro.org, dmitry.baryshkov@...aro.org,
 caleb.connolly@...aro.org, linux-kernel@...r.kernel.org, a39.skl@...il.com
Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: qrb4210-rb2: add description of
 lpi_i2s2 pins

On 02/10/2024 04:20, Alexey Klimov wrote:
> This is required to enable to HDMI audio playback on
> QRB4210 RB2 board.
> 
> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
> ---
>  arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 36 ++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index 1888d99d398b..7731681688d5 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -634,6 +634,42 @@ sdc2_card_det_n: sd-card-det-n-state {
>  	};
>  };
>  
> +&lpass_tlmm {
> +	lpi_i2s2_active: lpi-i2s2-active-state {
> +		sck-pin {

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Best regards,
Krzysztof