lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c7978538-04b4-406a-b8e3-70d3472ace7f@kernel.org>
Date: Wed, 2 Oct 2024 07:46:26 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gax-c <zichenxie0106@...il.com>, nbd@....name, lorenzo@...nel.org,
 ryder.lee@...iatek.com, shayne.chen@...iatek.com, sean.wang@...iatek.com,
 kvalo@...nel.org, matthias.bgg@...il.com,
 angelogioacchino.delregno@...labora.com, johannes.berg@...el.com,
 quic_adisi@...cinc.com, deren.wu@...iatek.com, chui-hao.chiu@...iatek.com,
 mingyen.hsieh@...iatek.com, howard-yh.hsu@...iatek.com,
 StanleyYP.Wang@...iatek.com, allen.ye@...iatek.com,
 benjamin-jw.lin@...iatek.com, Bo.Jiao@...iatek.com,
 evelyn.tsai@...iatek.com, meichia.chiu@...iatek.com
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 zzjas98@...il.com, chenyuan0y@...il.com
Subject: Re: [PATCH] wifi: mt76: Fix NULL Dereference caused by
 mt76_connac_get_he_phy_cap()

On 02/10/2024 01:59, Gax-c wrote:
> mt76_connac_get_he_phy_cap() may return a NULL pointer,
> leading to NULL Pointer Dereference.
> Add a NULL check for the returned pointer.
> 
> Fixes: a5c372f77aa7 ("wifi: mt76: mt7925: extend mt7925_mcu_bss_he_tlv for per-link BSS")
> Fixes: e6d557a78b60 ("mt76: mt7915: rely on mt76_connac_get_phy utilities")
> Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices")
> Signed-off-by: Zichen Xie <zichenxie0106@...il.com>
> Reported-by: Zichen Xie <zichenxie0106@...il.com>

You cannot report your own commits!

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ