linux-kernel - Re: [PATCH] sched/psi: fix unnecessary KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a848671f803ba2b4ab14b0f7b09f0f53a8dd1c4b.camel@perches.com>
Date: Tue, 01 Oct 2024 17:27:07 -0700
From: Joe Perches <joe@...ches.com>
To: Pintu Kumar <quic_pintu@...cinc.com>, hannes@...xchg.org,
 surenb@...gle.com,  peterz@...radead.org, mingo@...hat.com,
 juri.lelli@...hat.com,  vincent.guittot@...aro.org,
 dietmar.eggemann@....com, rostedt@...dmis.org,  bsegall@...gle.com,
 mgorman@...e.de, vschneid@...hat.com,  linux-kernel@...r.kernel.org
Cc: skhan@...uxfoundation.org, pintu.ping@...il.com
Subject: Re: [PATCH] sched/psi: fix unnecessary KERN_ERR and memory barrier
 comment

On Mon, 2024-09-30 at 19:21 +0530, Pintu Kumar wrote:
> These warnings were reported by checkpatch.
> Fix them with minor changes.
> 
> WARNING: Possible unnecessary KERN_ERR
> +                       printk_deferred(KERN_ERR "psi: task underflow! cpu=%d t=%d tasks=[%u %u %u %u] clear=%x set=%x\n",

printk_deferred does not have pr_<level>_deferred variants
so a KERN_<LEVEL> use here is appropriate.