linux-kernel - Re: [PATCH] sched/psi: fix unnecessary KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOuPNLhhAA31Ze23B=vQ8L30wYpRKXjYejUb5g8_wbz33eXzgg@mail.gmail.com>
Date: Thu, 3 Oct 2024 22:20:02 +0530
From: Pintu Agarwal <pintu.ping@...il.com>
To: Joe Perches <joe@...ches.com>
Cc: Pintu Kumar <quic_pintu@...cinc.com>, hannes@...xchg.org, surenb@...gle.com, 
	peterz@...radead.org, mingo@...hat.com, juri.lelli@...hat.com, 
	vincent.guittot@...aro.org, dietmar.eggemann@....com, rostedt@...dmis.org, 
	bsegall@...gle.com, mgorman@...e.de, vschneid@...hat.com, 
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH] sched/psi: fix unnecessary KERN_ERR and memory barrier comment

Hi Joe,

On Wed, 2 Oct 2024 at 05:57, Joe Perches <joe@...ches.com> wrote:
>
> On Mon, 2024-09-30 at 19:21 +0530, Pintu Kumar wrote:
> > These warnings were reported by checkpatch.
> > Fix them with minor changes.
> >
> > WARNING: Possible unnecessary KERN_ERR
> > +                       printk_deferred(KERN_ERR "psi: task underflow! cpu=%d t=%d tasks=[%u %u %u %u] clear=%x set=%x\n",
>
> printk_deferred does not have pr_<level>_deferred variants
> so a KERN_<LEVEL> use here is appropriate.
>
Thank you so much for your review.
Okay I will drop this one and only include the other one related to
"memory barrier missing comments".
Will send a v2 patch if you are okay with it.

Thanks,