linux-kernel - Re: [PATCH v3] gpio: add support for FTDI's MPSSE as GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZhSsU3K97gAmZhGhN_Jj72GhdQPQgJQpJAOjNXJqfw+w@mail.gmail.com>
Date: Wed, 2 Oct 2024 15:31:39 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Mary Strodl <mstrodl@....rit.edu>
Cc: linux-kernel@...r.kernel.org, brgl@...ev.pl, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3] gpio: add support for FTDI's MPSSE as GPIO

On Thu, Sep 26, 2024 at 2:44 PM Mary Strodl <mstrodl@....rit.edu> wrote:

> FTDI FT2232H is a USB to GPIO chip. Sealevel produces some devices
> with this chip. FT2232H presents itself as a composite device with two
> interfaces (each is an "MPSSE"). Each MPSSE has two banks (high and low)
> of 8 GPIO each. I believe some MPSSE's have only one bank, but I don't
> know how to identify them (I don't have any for testing) and as a result
> are unsupported for the time being.
>
> Additionally, this driver provides software polling-based interrupts for
> edge detection. For the Sealevel device I have to test with, this works
> well because there is hardware debouncing. From talking to Sealevel's
> people, this is their preferred way to do edge detection.
>
> Signed-off-by: Mary Strodl <mstrodl@....rit.edu>

All my review comments are addressed so with
Bartosz' nits addressed too:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij