linux-kernel - Re: [PATCH v3] gpio: add support for FTDI's MPSSE as GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zv7BjPfA3rV8fUBH@freedom.csh.rit.edu>
Date: Thu, 3 Oct 2024 12:08:44 -0400
From: Mary Strodl <mstrodl@...edom.csh.rit.edu>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Mary Strodl <mstrodl@....rit.edu>, linux-kernel@...r.kernel.org,
	linus.walleij@...aro.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3] gpio: add support for FTDI's MPSSE as GPIO

On Tue, Oct 01, 2024 at 09:04:58PM +0200, Bartosz Golaszewski wrote:
> I don't know much about the USB subsystem in the kernel, maybe Cc Greg
> KH on this?
Ok, I mostly just copied what I saw from other drivers.
 
> You could drop this label, all the gotos and the corresponding free in
> remove if you scheduled a devm action with devm_add_action_or_reset()
> right after getting the new index.
Thanks, didn't know about `devm_add_action_or_reset`! I was disappointed
to not find a `devm_ida_simple_get` when I wrote this, it is much cleaner
your way :)

> Overall it looks clean and nice but I can't tell if the USB-specific
> bits are correct.
> 
> Bart

Thanks for the review! I sent out a v4 that should hopefully address your feedback.

- Mary