linux-kernel - Re: [PATCH] Input: zinitix - Don't fail if linux,keycodes prop is absent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b37b70b52234017e0ade2710c276f3f@trvn.ru>
Date: Wed, 02 Oct 2024 19:48:57 +0500
From: Nikita Travkin <nikita@...n.ru>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
 linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, Jakob Hauser
 <jahau@...ketmail.com>
Subject: Re: [PATCH] Input: zinitix - Don't fail if linux,keycodes prop is
 absent

Linus Walleij писал(а) 02.10.2024 19:11:
> On Wed, Oct 2, 2024 at 3:02 PM Nikita Travkin <nikita@...n.ru> wrote:
> 
>> When initially adding the touchkey support, a mistake was made in the
>> property parsing code. The possible negative errno from
>> device_property_count_u32() was never checked, which was an oversight
>> left from converting to it from the of_property as part of the review
>> fixes.
>>
>> Re-add the correct handling of the absent property, in which case zero
>> touchkeys should be assumed, which would disable the feature.
>>
>> Reported-by: Jakob Hauser <jahau@...ketmail.com>
>> Tested-by: Jakob Hauser <jahau@...ketmail.com>
>> Fixes: 075d9b22c8fe ("Input: zinitix - add touchkey support")
>> Signed-off-by: Nikita Travkin <nikita@...n.ru>
> 
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> BTW: Nikita have you noticed and weird offsets in your Zinitix
> touchscreens? Mine seem to be off and I need to put my
> fingers a bit below the actual target on the screen, consistently.
> I was thinking maybe calibration support is necessary.

I for sure noticed this in the context of touchkeys: On the device I
have, if you don't enable the touchkeys, the controller assigns
the lines connected to them to the touch grid, which offsets
the real touchscreen by two lines. Effectively this means that
touch surface is stretched a bit below the screen, and i.e. touching
at the very bottom will produce a touch event a bit above
the actual touch point. Enabling touchkeys reassigns those lines
and then the display is working correctly.

This was the prime reason why I've even made the tkey series in
the first place :D

> 
> Yours,
> Linus Walleij