linux-kernel - Re: [PATCH] btrfs: Remove unused btrfs_free_squota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51b35809-bf9a-4b09-8df0-4eafc077d00f@gmx.com>
Date: Fri, 4 Oct 2024 06:40:20 +0930
From: Qu Wenruo <quwenruo.btrfs@....com>
To: linux@...blig.org, clm@...com, josef@...icpanda.com, dsterba@...e.com,
 boris@....io
Cc: rostedt@...dmis.org, mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
 linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: Remove unused btrfs_free_squota_rsv



在 2024/10/4 06:03, linux@...blig.org 写道:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> btrfs_free_squota_rsv() was added in commit
> e85a0adacf17 ("btrfs: ensure releasing squota reserve on head refs")
>
> but has remained unused.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Reviewed-by: Qu Wenruo <wqu@...e.com>

Thanks,
Qu
> ---
>   fs/btrfs/qgroup.c | 11 -----------
>   fs/btrfs/qgroup.h |  1 -
>   2 files changed, 12 deletions(-)
>
> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
> index c297909f1506..52f0cf7621d6 100644
> --- a/fs/btrfs/qgroup.c
> +++ b/fs/btrfs/qgroup.c
> @@ -4883,17 +4883,6 @@ void btrfs_qgroup_destroy_extent_records(struct btrfs_transaction *trans)
>   	xa_destroy(&trans->delayed_refs.dirty_extents);
>   }
>
> -void btrfs_free_squota_rsv(struct btrfs_fs_info *fs_info, u64 root, u64 rsv_bytes)
> -{
> -	if (btrfs_qgroup_mode(fs_info) != BTRFS_QGROUP_MODE_SIMPLE)
> -		return;
> -
> -	if (!is_fstree(root))
> -		return;
> -
> -	btrfs_qgroup_free_refroot(fs_info, root, rsv_bytes, BTRFS_QGROUP_RSV_DATA);
> -}
> -
>   int btrfs_record_squota_delta(struct btrfs_fs_info *fs_info,
>   			      const struct btrfs_squota_delta *delta)
>   {
> diff --git a/fs/btrfs/qgroup.h b/fs/btrfs/qgroup.h
> index 98adf4ec7b01..d72e09de2d64 100644
> --- a/fs/btrfs/qgroup.h
> +++ b/fs/btrfs/qgroup.h
> @@ -440,7 +440,6 @@ int btrfs_qgroup_trace_subtree_after_cow(struct btrfs_trans_handle *trans,
>   		struct btrfs_root *root, struct extent_buffer *eb);
>   void btrfs_qgroup_destroy_extent_records(struct btrfs_transaction *trans);
>   bool btrfs_check_quota_leak(const struct btrfs_fs_info *fs_info);
> -void btrfs_free_squota_rsv(struct btrfs_fs_info *fs_info, u64 root, u64 rsv_bytes);
>   int btrfs_record_squota_delta(struct btrfs_fs_info *fs_info,
>   			      const struct btrfs_squota_delta *delta);
>