[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aa56f811-4b80-4df6-92c5-c4f44f73f0f4@gmx.com>
Date: Fri, 4 Oct 2024 06:41:02 +0930
From: Qu Wenruo <quwenruo.btrfs@....com>
To: linux@...blig.org, clm@...com, josef@...icpanda.com, dsterba@...e.com,
hch@....de
Cc: rostedt@...dmis.org, mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: Remove unused btrfs_is_parity_mirror
在 2024/10/3 23:57, linux@...blig.org 写道:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> btrfs_is_parity_mirror() has been unused since commit
> 4886ff7b50f6 ("btrfs: introduce a new helper to submit write bio for repair")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
Reviewed-by: Qu Wenruo <wqu@...e.com>
Thanks,
Qu
> ---
> fs/btrfs/volumes.c | 18 ------------------
> fs/btrfs/volumes.h | 2 --
> 2 files changed, 20 deletions(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 8f340ad1d938..7453b4999263 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -5841,24 +5841,6 @@ unsigned long btrfs_full_stripe_len(struct btrfs_fs_info *fs_info,
> return len;
> }
>
> -int btrfs_is_parity_mirror(struct btrfs_fs_info *fs_info, u64 logical, u64 len)
> -{
> - struct btrfs_chunk_map *map;
> - int ret = 0;
> -
> - if (!btrfs_fs_incompat(fs_info, RAID56))
> - return 0;
> -
> - map = btrfs_get_chunk_map(fs_info, logical, len);
> -
> - if (!WARN_ON(IS_ERR(map))) {
> - if (map->type & BTRFS_BLOCK_GROUP_RAID56_MASK)
> - ret = 1;
> - btrfs_free_chunk_map(map);
> - }
> - return ret;
> -}
> -
> static int find_live_mirror(struct btrfs_fs_info *fs_info,
> struct btrfs_chunk_map *map, int first,
> int dev_replace_is_ongoing)
> diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
> index 03d2d60afe0c..715af107ea5d 100644
> --- a/fs/btrfs/volumes.h
> +++ b/fs/btrfs/volumes.h
> @@ -735,8 +735,6 @@ int btrfs_run_dev_stats(struct btrfs_trans_handle *trans);
> void btrfs_rm_dev_replace_remove_srcdev(struct btrfs_device *srcdev);
> void btrfs_rm_dev_replace_free_srcdev(struct btrfs_device *srcdev);
> void btrfs_destroy_dev_replace_tgtdev(struct btrfs_device *tgtdev);
> -int btrfs_is_parity_mirror(struct btrfs_fs_info *fs_info,
> - u64 logical, u64 len);
> unsigned long btrfs_full_stripe_len(struct btrfs_fs_info *fs_info,
> u64 logical);
> u64 btrfs_calc_stripe_length(const struct btrfs_chunk_map *map);
Powered by blists - more mailing lists