linux-kernel - Re: [PATCH 0/3] drivers: nubus: Fix coding style issues in nubus.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVUEBnohcsyiPpCF3QNdQeXXaU6pvVOY-5X8CHmRSvEJxXoyA@mail.gmail.com>
Date: Thu, 3 Oct 2024 09:01:32 +0530
From: Sayyad Abid <sayyad.abid16@...il.com>
To: Finn Thain <fthain@...ux-m68k.org>
Cc: linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org, 
	skhan@...uxfoundation.org
Subject: Re: [PATCH 0/3] drivers: nubus: Fix coding style issues in nubus.c

On Thu, Oct 3, 2024 at 4:25 AM Finn Thain <fthain@...ux-m68k.org> wrote:
>
>
> Hello sayyad.abid16@...il.com
>
> Thanks for taking the trouble to send e-mail messages to so many people by
> use of a free e-mail account.
>
> With regards to kernel patches, can I request that you --
>
> 1. Don't run checkpatch on existing code
> 2. Don't send patches that break the build
> 3. Don't claim to be improving code style by sending patches that violate
>    code style rules
> 4. Read the mailing lists and study the development process before trying
>    to contribute
>
> Thanks for your consideration.
>
> Regards
> Finn
>
> On Wed, 2 Oct 2024, Sayyad Abid wrote:
>
> > This patch series addresses coding style improvements in
> > the Nubus subsystem, specifically in `nubus.c`. These changes
> > aim to enhance readability and maintainability of the code.
> >
> > These coding style inconsistencies were found using checkpatch.pl
> >
> > Changes include:
> >  1. Improved comment block formatting by aligning `*` in
> >     multi-line comments.
> >  2. Fixing assignments inside conditional statements to improve clarity.
> >  3. Correcting the use of tabs for indentation in specific functions.
> >
> > Each commit focuses on a specific aspect, as detailed below.
> >
> >
> > Sayyad Abid (3):
> >   Fix use of tabs in nubus_get_vendorinfo and nubus_add_board
> >   Fix use of assignment in if condition in nubus_add_board()
> >   Fix use of * in comment block in nubus.c
> >
> >  drivers/nubus/nubus.c | 94 ++++++++++++++++++++++++-------------------
> >  1 file changed, 53 insertions(+), 41 deletions(-)
> >
> > --
> > 2.39.5
> >
> >
My sincere apologies for causing the trouble,
I overlooked a few things there,
I will keep a note of your points and make sure
that it is not repeated again.

Thank You!

-- 
Abid