linux-kernel - Re: [RFC PATCH 1/4] compiler.h: Introduce ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEXW_YTO3AhHAqrA4E_goVbsNB26AdfdShynr-nNMR97AYy6ag@mail.gmail.com>
Date: Thu, 3 Oct 2024 18:09:48 -0400
From: Joel Fernandes <joel@...lfernandes.org>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, Peter Zijlstra <peterz@...radead.org>, 
	linux-kernel@...r.kernel.org, Nicholas Piggin <npiggin@...il.com>, 
	Michael Ellerman <mpe@...erman.id.au>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, "Paul E. McKenney" <paulmck@...nel.org>, 
	Will Deacon <will@...nel.org>, Boqun Feng <boqun.feng@...il.com>, 
	Alan Stern <stern@...land.harvard.edu>, John Stultz <jstultz@...gle.com>, 
	Neeraj Upadhyay <Neeraj.Upadhyay@....com>, Frederic Weisbecker <frederic@...nel.org>, 
	Josh Triplett <josh@...htriplett.org>, Uladzislau Rezki <urezki@...il.com>, 
	Steven Rostedt <rostedt@...dmis.org>, Lai Jiangshan <jiangshanlai@...il.com>, 
	Zqiang <qiang.zhang1211@...il.com>, Ingo Molnar <mingo@...hat.com>, 
	Waiman Long <longman@...hat.com>, Mark Rutland <mark.rutland@....com>, 
	Thomas Gleixner <tglx@...utronix.de>, Vlastimil Babka <vbabka@...e.cz>, maged.michael@...il.com, 
	Mateusz Guzik <mjguzik@...il.com>, Jonas Oberhauser <jonas.oberhauser@...weicloud.com>, 
	rcu@...r.kernel.org, linux-mm@...ck.org, lkmm@...ts.linux.dev, 
	Gary Guo <gary@...yguo.net>, Nikita Popov <github@...pov.com>, llvm@...ts.linux.dev
Subject: Re: [RFC PATCH 1/4] compiler.h: Introduce ptr_eq() to preserve
 address dependency

On Thu, Oct 3, 2024 at 10:21 AM Mathieu Desnoyers
<mathieu.desnoyers@...icios.com> wrote:
> >
> > Reviewed-by: Joel Fernandes (Google) <joel@...lfernandes.org>
>
> Please double-check with -O2, and let me know if you still agree with
> the patch :)
>

You are quite right, with -O2 I can indeed see that the optimize hide
var fixes it.

FWIW:
Tested-by: Joel Fernandes (Google) <joel@...lfernandes.org>

Thanks!

 - Joel