linux-kernel - hwmon: pmbus: Question about header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241003223110.17166-1-vassilisamir@gmail.com>
Date: Fri,  4 Oct 2024 00:31:10 +0200
From: Vasileios Amoiridis <vassilisamir@...il.com>
To: jdelvare@...e.com,
	linux@...ck-us.net
Cc: vassilisamir@...il.com,
	vasileios.amoiridis@...n.ch,
	federico.vaga@...n.ch,
	linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: hwmon: pmbus: Question about header files

Hello hwmon and PMBUS community,

I am currently studying how the PMBUS subsystem works because I am trying to
write a driver for a PSU and submit for review. I noticed that the subsystem is
quite intelligent and it manages to do most of the stuff in the pmbus_core.c
leaving a minimum amount of work to be done in the actual device driver!!

I have a question though, regarding the header files <include/linux/pmbus.h> and
<drivers/hwmon/pmbus/pmbus.h>. With my limited experience in kernel development,
I would expect that the drivers/hwmon/pmbus/pmbus.h file would include stuff
that are used only by the pmbus_core.c/pmbus.c while anything that could be
potentially used from the device drivers would go to the include/linux/pmbus.h.

Is my reasoning wrong? What was the reasoning behind the split between those 2
files?

Thanks a lot for your time!

Best regards,
Vasilis