linux-kernel - Re: hwmon: pmbus: Question about header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d220f9d1-54df-4d4e-b90f-69bc5de5a22f@roeck-us.net>
Date: Fri, 4 Oct 2024 14:22:55 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Vasileios Amoiridis <vassilisamir@...il.com>, jdelvare@...e.com
Cc: vasileios.amoiridis@...n.ch, federico.vaga@...n.ch,
 linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: hwmon: pmbus: Question about header files

On 10/3/24 15:31, Vasileios Amoiridis wrote:
> Hello hwmon and PMBUS community,
> 
> I am currently studying how the PMBUS subsystem works because I am trying to
> write a driver for a PSU and submit for review. I noticed that the subsystem is
> quite intelligent and it manages to do most of the stuff in the pmbus_core.c
> leaving a minimum amount of work to be done in the actual device driver!!
> 
> I have a question though, regarding the header files <include/linux/pmbus.h> and
> <drivers/hwmon/pmbus/pmbus.h>. With my limited experience in kernel development,
> I would expect that the drivers/hwmon/pmbus/pmbus.h file would include stuff
> that are used only by the pmbus_core.c/pmbus.c while anything that could be
> potentially used from the device drivers would go to the include/linux/pmbus.h.
> 
> Is my reasoning wrong? What was the reasoning behind the split between those 2
> files?
> 

Mostly historic. The original idea was to keep platform data in include/linux,
but at this point that has pretty much no value since all its users are (and
should be) in drivers/hwmon/pmbus/. Not worth doing anything about.

Guenter