[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <14D5E109-9389-47E7-A3D6-557B85452495@gmail.com>
Date: Thu, 3 Oct 2024 14:26:19 +0800
From: zhang warden <zhangwarden@...il.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: Miroslav Benes <mbenes@...e.cz>,
Jiri Kosina <jikos@...nel.org>,
Petr Mladek <pmladek@...e.com>,
Joe Lawrence <joe.lawrence@...hat.com>,
live-patching@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 1/1] livepatch: Add "stack_order" sysfs attribute
Hi, Josh!
> On Oct 1, 2024, at 07:26, Josh Poimboeuf <jpoimboe@...nel.org> wrote:
>>
>> diff --git a/Documentation/ABI/testing/sysfs-kernel-livepatch b/Documentation/ABI/testing/sysfs-kernel-livepatch
>> index a5df9b4910dc..2a60b49aa9a5 100644
>> --- a/Documentation/ABI/testing/sysfs-kernel-livepatch
>> +++ b/Documentation/ABI/testing/sysfs-kernel-livepatch
>> @@ -47,6 +47,14 @@ Description:
>> disabled when the feature is used. See
>> Documentation/livepatch/livepatch.rst for more information.
>>
>> +What: /sys/kernel/livepatch/<patch>/stack_order
>> +Date: Sep 2024
>> +KernelVersion: 6.12.0
>
> These will probably need to be updated (can probably be done by Petr when
> applying).
>
True, kernel version may need Petr to decide.
>> +Contact: live-patching@...r.kernel.org
>> +Description:
>> + This attribute holds the stack order of a livepatch module applied
>> + to the running system.
>
> It's probably a good idea to clarify what "stack order" means. Also,
> try to keep the text under 80 columns for consistency.
>
> How about:
>
> This attribute indicates the order the patch was applied
> compared to other patches. For example, a stack_order value of
> '2' indicates the patch was applied after the patch with stack
> order '1' and before any other currently applied patches.
>
Or how about:
This attribute indicates the order of the livepatch module
applied to the system. The stack_order value N means
that this module is the Nth applied to the system. If there
are serval patches changing the same function, the function
version of the biggest stack_order is enabling in the system.
Regards.
Wardenjohn.
Powered by blists - more mailing lists