[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241003093840.2965be20@xps-13>
Date: Thu, 3 Oct 2024 09:38:40 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Han Xu <han.xu@....com>
Cc: Richard Weinberger <richard@....at>, Vignesh Raghavendra
<vigneshr@...com>, imx@...ts.linux.dev, linux-mtd@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] mtd: nand: raw: gpmi: improve power management
handling
Hi Han,
han.xu@....com wrote on Wed, 2 Oct 2024 10:39:44 -0500:
> The commit refactors the power management handling in the gpmi nand
> driver. It removes redundant pm_runtime calls in the probe function,
> handles the pad control in suspend and resume, and moves the calls to
> acquire and release DMA channels to the runtime suspend and resume
> functions.
May I know the motivation to acquire and release the DMA channels
during suspend? In general it seems like a different change which I'd
prefer to see in its own commit with a justification. The rest looks
ok otherwise.
Thanks,
Miquèl
Powered by blists - more mailing lists