linux-kernel - Re: [PATCH v2 2/2] mtd: nand: raw: gpmi: improve power management handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241003150500.uz2efay7kadu47if@cozumel>
Date: Thu, 3 Oct 2024 10:05:16 -0500
From: Han Xu <han.xu@....com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Richard Weinberger <richard@....at>,
	Vignesh Raghavendra <vigneshr@...com>, imx@...ts.linux.dev,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] mtd: nand: raw: gpmi: improve power management
 handling

On 24/10/03 09:38AM, Miquel Raynal wrote:
> Hi Han,
> 
> han.xu@....com wrote on Wed,  2 Oct 2024 10:39:44 -0500:
> 
> > The commit refactors the power management handling in the gpmi nand
> > driver. It removes redundant pm_runtime calls in the probe function,
> > handles the pad control in suspend and resume, and moves the calls to
> > acquire and release DMA channels to the runtime suspend and resume
> > functions.
> 
> May I know the motivation to acquire and release the DMA channels
> during suspend? In general it seems like a different change which I'd
> prefer to see in its own commit with a justification. The rest looks
> ok otherwise.

Hi Miquel,

Thanks for your comments. IMHO there is no much logic changes indeed, just move
the dma channel acquire and release from system pm to the runtime pm, releasing
the unused resources as early as possible. If you think it's necessary I will
split the patch into two parts.

> 
> Thanks,
> Miquèl