linux-kernel - Re: [PATCH V3 1/1] livepatch: Add "stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A7799C9D-52EF-4C9A-9C22-1B98AAAD997A@gmail.com>
Date: Thu, 3 Oct 2024 22:59:11 +0800
From: zhang warden <zhangwarden@...il.com>
To: Petr Mladek <pmladek@...e.com>
Cc: Josh Poimboeuf <jpoimboe@...nel.org>,
 Miroslav Benes <mbenes@...e.cz>,
 Jiri Kosina <jikos@...nel.org>,
 Joe Lawrence <joe.lawrence@...hat.com>,
 live-patching@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 1/1] livepatch: Add "stack_order" sysfs attribute


Hi, Petr.
> Also please rebase the patch on top of current Linus' master or
> v6.11. There are conflicts with the commit adb68ed26a3e922
> ("livepatch: Add "replace" sysfs attribute").
> 
OK, will fix it.

>>>> +Contact:        live-patching@...r.kernel.org
>>>> +Description:
>>>> + This attribute holds the stack order of a livepatch module applied
>>>> + to the running system.
>>> 
>>> It's probably a good idea to clarify what "stack order" means.  Also,
>>> try to keep the text under 80 columns for consistency.
>>> 
>>> How about:
>>> 
>>> This attribute indicates the order the patch was applied
>>> compared to other patches.  For example, a stack_order value of
>>> '2' indicates the patch was applied after the patch with stack
>>> order '1' and before any other currently applied patches.
>>> 
>> 
>> Or how about:
>> 
>> This attribute indicates the order of the livepatch module 
>> applied to the system. The stack_order value N means 
>> that this module is the Nth applied to the system. If there
>> are serval patches changing the same function, the function
>> version of the biggest stack_order is enabling in the system.
> 
> The 2nd sentence looks superfluous. The 3rd sentence explains
> the important effect.
> 
> Well, the part "is enabling in the system" is a bit cryptic.
> I would write something like:
> 
> This attribute specifies the sequence in which live patch modules
> are applied to the system. If multiple live patches modify the same
> function, the implementation with the highest stack order is used,
> unless a transition is currently in progress.

This description looks good to me. What's the suggestion of 
other maintainers ?

Regards.
Wardenjohn.