linux-kernel - Re: [PATCH 1/3] rust: implement `kernel::sync::Refcount`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874j5rptbb.fsf@kernel.org>
Date: Fri, 04 Oct 2024 21:22:00 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Gary Guo" <gary@...yguo.net>
Cc: "Miguel Ojeda" <ojeda@...nel.org>,  "Alex Gaynor"
 <alex.gaynor@...il.com>,  "Boqun Feng" <boqun.feng@...il.com>,
  Björn Roy
 Baron <bjorn3_gh@...tonmail.com>,  "Benno Lossin"
 <benno.lossin@...ton.me>,  "Alice Ryhl" <aliceryhl@...gle.com>,  "Trevor
 Gross" <tmgross@...ch.edu>,  "Martin Rodriguez Reboredo"
 <yakoyoku@...il.com>,  "Will Deacon" <will@...nel.org>,  "Peter Zijlstra"
 <peterz@...radead.org>,  "Mark Rutland" <mark.rutland@....com>,  "Dirk
 Behme" <dirk.behme@...bosch.com>,  <linux-kernel@...r.kernel.org>,
  <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH 1/3] rust: implement `kernel::sync::Refcount`

"Gary Guo" <gary@...yguo.net> writes:

> On Fri, 04 Oct 2024 20:51:22 +0200
> Andreas Hindborg <a.hindborg@...nel.org> wrote:
>
>> Hi Gary,
>>
>> "Gary Guo" <gary@...yguo.net> writes:
>>
>> [...]
>>
>> > diff --git a/rust/helpers/refcount.c b/rust/helpers/refcount.c
>> > index f47afc148ec3..39649443426b 100644
>> > --- a/rust/helpers/refcount.c
>> > +++ b/rust/helpers/refcount.c
>> > @@ -8,11 +8,26 @@ refcount_t rust_helper_REFCOUNT_INIT(int n)
>> >  	return (refcount_t)REFCOUNT_INIT(n);
>> >  }
>> >
>> > +unsigned int rust_helper_refcount_read(refcount_t *r)
>> > +{
>> > +	return refcount_read(r);
>> > +}
>>
>> +EXPORT_SYMBOL_GPL(rust_helper_refcount_read);
>>
>> > +
>> > +void rust_helper_refcount_set(refcount_t *r, int n)
>> > +{
>> > +	refcount_set(r, n);
>> > +}
>>
>> +EXPORT_SYMBOL_GPL(rust_helper_refcount_set);
>>
>> BR Andreas
>>
>
> Helper symbol export is automatic after
> e26fa546042a (rust: kbuild: auto generate helper exports)

All good then 👍 I was applying to 6.11 and got some build errors.
Downstream `rnull` is still on 6.11.

Benchmarks will run next week.

BR Andreas