linux-kernel - Re: [PATCH 1/3] rust: implement `kernel::sync::Refcount`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66651971-5d4b-44a3-9c6e-2aed6a7cfacc@gmail.com>
Date: Sat, 5 Oct 2024 08:04:02 +0200
From: Dirk Behme <dirk.behme@...il.com>
To: Gary Guo <gary@...yguo.net>, Andreas Hindborg <a.hindborg@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno Lossin <benno.lossin@...ton.me>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 Martin Rodriguez Reboredo <yakoyoku@...il.com>, Will Deacon
 <will@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 Mark Rutland <mark.rutland@....com>, Dirk Behme <dirk.behme@...bosch.com>,
 linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH 1/3] rust: implement `kernel::sync::Refcount`

Am 04.10.24 um 21:08 schrieb Gary Guo:
> On Fri, 04 Oct 2024 20:51:22 +0200
> Andreas Hindborg <a.hindborg@...nel.org> wrote:
> 
>> Hi Gary,
>>
>> "Gary Guo" <gary@...yguo.net> writes:
>>
>> [...]
>>
>>> diff --git a/rust/helpers/refcount.c b/rust/helpers/refcount.c
>>> index f47afc148ec3..39649443426b 100644
>>> --- a/rust/helpers/refcount.c
>>> +++ b/rust/helpers/refcount.c
>>> @@ -8,11 +8,26 @@ refcount_t rust_helper_REFCOUNT_INIT(int n)
>>>   	return (refcount_t)REFCOUNT_INIT(n);
>>>   }
>>>
>>> +unsigned int rust_helper_refcount_read(refcount_t *r)
>>> +{
>>> +	return refcount_read(r);
>>> +}
>>
>> +EXPORT_SYMBOL_GPL(rust_helper_refcount_read);
>>
>>> +
>>> +void rust_helper_refcount_set(refcount_t *r, int n)
>>> +{
>>> +	refcount_set(r, n);
>>> +}
>>
>> +EXPORT_SYMBOL_GPL(rust_helper_refcount_set);
>>
>> BR Andreas
>>
> 
> Helper symbol export is automatic after
> e26fa546042a (rust: kbuild: auto generate helper exports)

Yes :)

What results in a question, though:

When to use exports.h and when not?

There are several users of

#include <linux/export.h>

like

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/rust/helpers/err.c
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/rust/helpers/kunit.c
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/rust/helpers/mutex.c

but some don't use it

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/rust/helpers/rbtree.c
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/rust/helpers/uaccess.c

Any rule?

Best regards

Dirk