linux-kernel - Re: [PATCH sched_ext/for-6.12-fixes] sched_ext: Improve error reporting during loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwBMDpTJMyq1z7-s@slm.duckdns.org>
Date: Fri, 4 Oct 2024 10:11:58 -1000
From: Tejun Heo <tj@...nel.org>
To: David Vernet <void@...ifault.com>
Cc: linux-kernel@...r.kernel.org, kernel-team@...a.com, sched-ext@...a.com,
	Daniel Hodges <hodges.daniel.scott@...il.com>,
	Changwoo Min <multics69@...il.com>,
	Andrea Righi <andrea.righi@...ux.dev>,
	Dan Schatzberg <schatzberg.dan@...il.com>
Subject: Re: [PATCH sched_ext/for-6.12-fixes] sched_ext: Improve error
 reporting during loading

On Wed, Oct 02, 2024 at 10:33:37AM -1000, Tejun Heo wrote:
> When the BPF scheduler fails, ops.exit() allows rich error reporting through
> scx_exit_info. Use scx.exit() path consistently for all failures which can
> be caused by the BPF scheduler:
> 
> - scx_ops_error() is called after ops.init() and ops.cgroup_init() failure
>   to record error information.
> 
> - ops.init_task() failure now uses scx_ops_error() instead of pr_err().
> 
> - The err_disable path updated to automatically trigger scx_ops_error() to
>   cover cases that the error message hasn't already been generated and
>   always return 0 indicating init success so that the error is reported
>   through ops.exit().
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: David Vernet <void@...ifault.com>
> Cc: Daniel Hodges <hodges.daniel.scott@...il.com>
> Cc: Changwoo Min <multics69@...il.com>
> Cc: Andrea Righi <andrea.righi@...ux.dev>
> Cc: Dan Schatzberg <schatzberg.dan@...il.com>

Applied to sched_ext/for-6.12-fixes.

Thanks.

-- 
tejun