linux-kernel - Re: [PATCH sched_ext/for-6.12-fixes] sched_ext: scx_cgroup_exit() may be called without successful scx_cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZwBMKoANSjGzjAhp@slm.duckdns.org>
Date: Fri, 4 Oct 2024 10:12:26 -1000
From: Tejun Heo <tj@...nel.org>
To: David Vernet <void@...ifault.com>
Cc: linux-kernel@...r.kernel.org, kernel-team@...a.comm, sched-ext@...a.com
Subject: Re: [PATCH sched_ext/for-6.12-fixes] sched_ext: scx_cgroup_exit()
 may be called without successful scx_cgroup_init()

On Wed, Oct 02, 2024 at 10:34:38AM -1000, Tejun Heo wrote:
> 568894edbe48 ("sched_ext: Add scx_cgroup_enabled to gate cgroup operations
> and fix scx_tg_online()") assumed that scx_cgroup_exit() is only called
> after scx_cgroup_init() finished successfully. This isn't true.
> scx_cgroup_exit() can be called without scx_cgroup_init() being called at
> all or after scx_cgroup_init() failed in the middle.
> 
> As init state is tracked per cgroup, scx_cgroup_exit() can be used safely to
> clean up in all cases. Remove the incorrect WARN_ON_ONCE().
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Fixes: 568894edbe48 ("sched_ext: Add scx_cgroup_enabled to gate cgroup operations and fix scx_tg_online()")

Applied to sched_ext/for-6.12-fixes.

Thanks.

-- 
tejun