linux-kernel - Re: [PATCH v4] dt-bindings: display: mediatek: split: add subschema property constraints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00fe988ac57393eb7dcc837631f2a94bc5e95c0b.camel@mediatek.com>
Date: Fri, 4 Oct 2024 07:16:23 +0000
From: Moudy Ho (何宗原) <Moudy.Ho@...iatek.com>
To: "krzk@...nel.org" <krzk@...nel.org>
CC: "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
	Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>,
	"tzimmermann@...e.de" <tzimmermann@...e.de>, "simona@...ll.ch"
	<simona@...ll.ch>, "mripard@...nel.org" <mripard@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, Macpaul Lin (林智斌)
	<Macpaul.Lin@...iatek.com>, "airlied@...il.com" <airlied@...il.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v4] dt-bindings: display: mediatek: split: add subschema
 property constraints

Hi Krzysztof,

On Fri, 2024-10-04 at 08:35 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Fri, Oct 04, 2024 at 11:12:45AM +0800, Moudy Ho wrote:
> > The display node in mt8195.dtsi was triggering a CHECK_DTBS error
> due
> > to an excessively long 'clocks' property:
> >   display@...06000: clocks: [[31, 14], [31, 43], [31, 44]] is too
> long
> > 
> > To resolve this issue, the constraints for 'clocks' and
> > other properties within the subschema will be reinforced.
> > 
> > Fixes: 739058a9c5c3 ("dt-bindings: display: mediatek: split: add
> compatible for MT8195")
> > Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
> > Signed-off-by: Moudy Ho <moudy.ho@...iatek.com>
> > 
> > --
> > This is based on [v2] dt-bindings: display: mediatek: split: add
> clocks count constraint for MT8195
> > 
> > Changes since v3:
> >   - Correct the compatible name for the mt8173 split in the
> subschema.
> > 
> > Changes since v2:
> >   - Revise the commit message.
> >   - Enhance the descriptions of 'clocks'.
> >   - Strengthen the conditions within the subschema.
> > 
> > Changes since v1:
> >   - Adding functional descriptions and quantity restrictions.
> > ---
> >  .../display/mediatek/mediatek,split.yaml      | 24
> +++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> > 
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> > index e4affc854f3d..87f8477a7be8 100644
> > ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> > +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> > @@ -57,6 +57,9 @@ properties:
> >    clocks:
> >      items:
> >        - description: SPLIT Clock
> > +      - description: Used for interfacing with the HDMI RX signal
> source.
> > +      - description: Paired with receiving HDMI RX metadata.
> > +    minItems: 1
> >  
> >  required:
> >    - compatible
> > @@ -72,9 +75,30 @@ allOf:
> >              const: mediatek,mt8195-mdp3-split
> >  
> >      then:
> > +      properties:
> > +        clocks:
> 
> minItems, nothing in your commit msg says that clocks are optional
> 

Thanks for the reminder. I misunderstood the implications of using
min/max.

> > +          maxItems: 3
> > +
> > +        power-domains:
> > +          maxItems: 1
> 
> This should be in top-level, not here.
> 
> Best regards,
> Krzysztof
> 

The above two will be corrected in the next version.

Sincerely,
Moudy Ho