linux-kernel - Re: [PATCH] drm/panic: Select ZLIB_DEFLATE for DRM_PANIC_SCREEN_QR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <609cf7e5-0fd6-4636-b5b1-b63fe319db28@redhat.com>
Date: Fri, 4 Oct 2024 09:14:07 +0200
From: Jocelyn Falempe <jfalempe@...hat.com>
To: Miguel Ojeda <ojeda@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 patches@...ts.linux.dev
Subject: Re: [PATCH] drm/panic: Select ZLIB_DEFLATE for
 DRM_PANIC_SCREEN_QR_CODE

On 04/10/2024 01:07, Miguel Ojeda wrote:
> Under `CONFIG_DRM_PANIC_SCREEN_QR_CODE=y`, zlib is used:
> 
>      ld.lld: error: undefined symbol: zlib_deflate_workspacesize
>      >>> referenced by drm_panic.c
>      >>>               drivers/gpu/drm/drm_panic.o:(drm_panic_qr_init) in archive vmlinux.a
> 
> Thus select `CONFIG_ZLIB_DEFLATE`.

Hi, good catch, yes it should select the zlib deflate.

Reviewed-by: Jocelyn Falempe <jfalempe@...hat.com>

Best regards,

-- 

Jocelyn

> 
> Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen")
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>
> ---
>   drivers/gpu/drm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 1cb5a4f19293..cf5bc77e2362 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -152,6 +152,7 @@ config DRM_PANIC_SCREEN
>   config DRM_PANIC_SCREEN_QR_CODE
>   	bool "Add a panic screen with a QR code"
>   	depends on DRM_PANIC && RUST
> +	select ZLIB_DEFLATE
>   	help
>   	  This option adds a QR code generator, and a panic screen with a QR
>   	  code. The QR code will contain the last lines of kmsg and other debug
> --
> 2.46.2
>