linux-kernel - Re: [PATCH] drm/panic: Select ZLIB_DEFLATE for DRM_PANIC_SCREEN_QR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e8b90d70-d5dd-4ae9-8088-ca940d1fd9fa@redhat.com>
Date: Mon, 14 Oct 2024 14:48:29 +0200
From: Jocelyn Falempe <jfalempe@...hat.com>
To: Miguel Ojeda <ojeda@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 patches@...ts.linux.dev
Subject: Re: [PATCH] drm/panic: Select ZLIB_DEFLATE for
 DRM_PANIC_SCREEN_QR_CODE

On 04/10/2024 09:14, Jocelyn Falempe wrote:
> On 04/10/2024 01:07, Miguel Ojeda wrote:
>> Under `CONFIG_DRM_PANIC_SCREEN_QR_CODE=y`, zlib is used:
>>
>>      ld.lld: error: undefined symbol: zlib_deflate_workspacesize
>>      >>> referenced by drm_panic.c
>>      >>>               drivers/gpu/drm/drm_panic.o:(drm_panic_qr_init) 
>> in archive vmlinux.a
>>
>> Thus select `CONFIG_ZLIB_DEFLATE`.
> 
> Hi, good catch, yes it should select the zlib deflate.
> 
> Reviewed-by: Jocelyn Falempe <jfalempe@...hat.com>

I've just pushed it to drm-misc-next.

Thanks for your contribution.

-- 

Jocelyn

> 
> Best regards,
>