linux-kernel - Re: [PATCH v2 1/2] dt-bindings: net: bluetooth: nxp: Add support for power save feature using GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS4PR04MB969238D42394A9FDDAFD2F83E7722@AS4PR04MB9692.eurprd04.prod.outlook.com>
Date: Fri, 4 Oct 2024 07:36:30 +0000
From: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "marcel@...tmann.org" <marcel@...tmann.org>, "luiz.dentz@...il.com"
	<luiz.dentz@...il.com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "linux-bluetooth@...r.kernel.org"
	<linux-bluetooth@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, Amitkumar Karwar <amitkumar.karwar@....com>,
	Rohit Fule <rohit.fule@....com>, Sherry Sun <sherry.sun@....com>, Luke Wang
	<ziniu.wang_1@....com>, Bough Chen <haibo.chen@....com>, LnxRevLi
	<LnxRevLi@....com>
Subject: Re: [PATCH v2 1/2] dt-bindings: net: bluetooth: nxp: Add support for
 power save feature using GPIO

Hi Krzysztof,

Thank you for the review.

> 
> On Thu, Oct 03, 2024 at 09:15:06PM +0530, Neeraj Sanjay Kale wrote:
> > This adds a new optional device tree property h2c-ps-gpios, which
> > specifies the GPIO connected to BT_WAKE_IN pin of the NXP chipset.
> >
> > If this property is defined, the driver will use this GPIO for driving
> > chip into sleep/wakeup state, else use the UART break signal by default.
> >
> > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
> > ---
> > v2: Rephrase description and use "-gpios". (Krzysztof, Rob)
> > ---
> >  .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8
> > ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > index 37a65badb448..cd8236eb31de 100644
> > ---
> > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.y
> > +++ aml
> > @@ -34,6 +34,12 @@ properties:
> >    firmware-name:
> >      maxItems: 1
> >
> > +  h2c-ps-gpios:
> > +    maxItems: 1
> > +    description:
> > +      Host-To-Chip power save mechanism is driven by this GPIO
> > +      connected to BT_WAKE_IN pin of the NXP chipset.
> 
> So this should be wakeup-gpios or device-wakeup-gpios?
> 
Yes, if that's the preferred name, let me quickly change it to device-wakeup-gpios.
There may be a different feature implementation in near future for host wake-up. So wakeup-gpios may seem confusing then.

Thanks,
Neeraj