[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <79d9aeef-2b38-44c5-a371-f696f6ae1de3@kernel.org>
Date: Fri, 4 Oct 2024 10:38:22 +0300
From: Roger Quadros <rogerq@...nel.org>
To: Andreas Kemnade <andreas@...nade.info>, Conor Dooley
<conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
khilman@...libre.com, devicetree@...r.kernel.org, tony@...mide.com,
aaro.koskinen@....fi, linux-omap@...r.kernel.org
Subject: Re: [PATCH 2/4] ARM: dts: omap: omap4-epson-embt2ws: wire up
regulators
On 01/10/2024 00:30, Andreas Kemnade wrote:
> Wire up the regulators where usage is plausible. Do not
> wire them if purpose/usage is unclear like 5V for
> many things requiring lower voltages.
>
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---
> arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> index d6b0abba19f6..cc1b6080bf95 100644
> --- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> +++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> @@ -20,13 +20,13 @@ memory@...00000 {
> backlight-left {
> compatible = "pwm-backlight";
> pwms = <&twl_pwm 1 7812500>;
> - power-supply = <&unknown_supply>;
> + power-supply = <&lb_v50>;
This is probably wrong. I noticed this while reviewing patch 3.
you probably want to wire this to blc_l?
> };
>
> backlight-right {
> compatible = "pwm-backlight";
> pwms = <&twl_pwm 0 7812500>;
> - power-supply = <&unknown_supply>;
> + power-supply = <&lb_v50>;
this one should be wired to blc_r?
> };
>
> cb_v18: cb-v18 {
> @@ -95,11 +95,6 @@ lb_v50: lb-v50 {
> enable-active-high;
> };
>
> - unknown_supply: unknown-supply {
> - compatible = "regulator-fixed";
> - regulator-name = "unknown";
> - };
> -
> wl12xx_pwrseq: wl12xx-pwrseq {
> compatible = "mmc-pwrseq-simple";
> clocks = <&twl 1>;
> @@ -308,6 +303,8 @@ mpu9150: imu@68 {
> pinctrl-0 = <&mpu9150_pins>;
> interrupt-parent = <&gpio2>;
> interrupt = <7 IRQ_TYPE_LEVEL_HIGH>;
> + vddio-supply = <&cb_v18>;
> + vdd-supply = <&cb_v33>;
> invensense,level-shifter;
> };
> };
--
cheers,
-roger
Powered by blists - more mailing lists