linux-kernel - Re: [PATCH 1/4] ARM: dts: omap: omap4-epson-embt2ws: define GPIO regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bf32fb2-6b1d-4527-8ca2-96e21b8a813e@kernel.org>
Date: Fri, 4 Oct 2024 10:55:02 +0300
From: Roger Quadros <rogerq@...nel.org>
To: Andreas Kemnade <andreas@...nade.info>
Cc: Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-kernel@...r.kernel.org,
 Rob Herring <robh@...nel.org>, khilman@...libre.com,
 devicetree@...r.kernel.org, tony@...mide.com, aaro.koskinen@....fi,
 linux-omap@...r.kernel.org
Subject: Re: [PATCH 1/4] ARM: dts: omap: omap4-epson-embt2ws: define GPIO
 regulators



On 04/10/2024 10:41, Andreas Kemnade wrote:
> Am Fri, 4 Oct 2024 10:24:32 +0300
> schrieb Roger Quadros <rogerq@...nel.org>:
> 
>> On 01/10/2024 00:30, Andreas Kemnade wrote:
>>> To properly have things running after cold boot, define
>>> GPIO regulators. Naming is based on board file.
>>>
>>> In the vendor kernel they are enabled in a function
>>> called bt2ws_dcdc_init() if the system is not booted just
>>> to charge the battery.
>>>
>>> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
>>> ---
>>>  .../boot/dts/ti/omap/omap4-epson-embt2ws.dts  | 73
>>> +++++++++++++++++++ 1 file changed, 73 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
>>> b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts index
>>> 339e52ba3614..d6b0abba19f6 100644 ---
>>> a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts +++
>>> b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts @@ -29,6 +29,42
>>> @@ backlight-right { power-supply = <&unknown_supply>;
>>>  	};
>>>  
>>> +	cb_v18: cb-v18 {  
>>
>> https://devicetree-specification.readthedocs.io/en/v0.3/devicetree-basics.html#generic-names-recommendation
>>
>>
>> So regulator@n
>> where n is some index if it can't be address.
>>
> No, no @n. The above link says: "If the node has no reg property, the
> @unit-address must be omitted and the node-name alone differentiates
> the node from other nodes at the same level in the tree." So
> probably regulator-cb-v18.

Yes, I agree.

-- 
cheers,
-roger