[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DA1815FE-D2A6-46A3-9219-9216A3C6D61A@public-files.de>
Date: Sat, 05 Oct 2024 21:41:02 +0200
From: Frank Wunderlich <frank-w@...lic-files.de>
To: Rob Herring <robh@...nel.org>, Frank Wunderlich <linux@...web.de>
CC: Linus Walleij <linus.walleij@...aro.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
Sean Wang <sean.wang@...nel.org>, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
daniel@...rotopia.org, john@...ozen.org, ansuelsmth@...il.com,
eladwf@...il.com
Subject: Re: [PATCH v1 3/4] dt-bindings: pinctrl: add binding for MT7988 SoC
Hi Rob
Thank you for first review
Am 5. Oktober 2024 20:44:49 MESZ schrieb Rob Herring <robh@...nel.org>:
>On Fri, Oct 04, 2024 at 02:34:17PM +0200, Frank Wunderlich wrote:
>> +patternProperties:
>> + '-pins$':
>> + type: object
>> + additionalProperties: false
>> +
>> + patternProperties:
>> + '^.*mux.*$':
>
>Do you really need 'mux' anywhere in the name?
>
>> + type: object
>> + additionalProperties: false
>> + description: |
>> + pinmux configuration nodes.
...
>> + '^.*conf.*$':
>
>Really need 'conf' anywhere in the name?
>
>> + type: object
>> + additionalProperties: false
>> + description:
>> + pinconf configuration nodes.
>> + $ref: /schemas/pinctrl/pincfg-node.yaml
mux and conf are used to match subnodes see example for mdio0_pins
mdio0_pins: mdio0-pins {
mux {
function = "eth";
groups = "mdc_mdio0";
};
conf {
pins = "SMI_0_MDC", "SMI_0_MDIO";
drive-strength = <MTK_DRIVE_8mA>;
};
};
This is same as done for previous SoC like mt7986.
regards Frank
Powered by blists - more mailing lists