linux-kernel - Re: [PATCH v1 3/4] dt-bindings: pinctrl: add binding for MT7988 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKvJHf0OFpQf0uWeoqyCEvA4gdAyCdd7fD83_qQRSMErA@mail.gmail.com>
Date: Mon, 7 Oct 2024 11:08:19 -0500
From: Rob Herring <robh@...nel.org>
To: frank-w@...lic-files.de
Cc: Frank Wunderlich <linux@...web.de>, Linus Walleij <linus.walleij@...aro.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Sean Wang <sean.wang@...nel.org>, 
	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org, daniel@...rotopia.org, john@...ozen.org, 
	ansuelsmth@...il.com, eladwf@...il.com
Subject: Re: [PATCH v1 3/4] dt-bindings: pinctrl: add binding for MT7988 SoC

On Sat, Oct 5, 2024 at 2:41 PM Frank Wunderlich <frank-w@...lic-files.de> wrote:
>
> Hi Rob
>
> Thank you for first review
>
> Am 5. Oktober 2024 20:44:49 MESZ schrieb Rob Herring <robh@...nel.org>:
> >On Fri, Oct 04, 2024 at 02:34:17PM +0200, Frank Wunderlich wrote:
>
> >> +patternProperties:
> >> +  '-pins$':
> >> +    type: object
> >> +    additionalProperties: false
> >> +
> >> +    patternProperties:
> >> +      '^.*mux.*$':
> >
> >Do you really need 'mux' anywhere in the name?
> >
> >> +        type: object
> >> +        additionalProperties: false
> >> +        description: |
> >> +          pinmux configuration nodes.
> ...
> >> +      '^.*conf.*$':
> >
> >Really need 'conf' anywhere in the name?
> >
> >> +        type: object
> >> +        additionalProperties: false
> >> +        description:
> >> +          pinconf configuration nodes.
> >> +        $ref: /schemas/pinctrl/pincfg-node.yaml
>
> mux and conf are used to match subnodes see example for mdio0_pins
>
> mdio0_pins: mdio0-pins {
>   mux {
>     function = "eth";
>     groups = "mdc_mdio0";
>   };
>
>   conf {
>     pins = "SMI_0_MDC", "SMI_0_MDIO";
>     drive-strength = <MTK_DRIVE_8mA>;
>   };
> };
>
> This is same as done for previous SoC like mt7986.

Why do you need foomuxbar? Please define a prefix or suffix (separated
by a '-') or just a fixed string.

Either we missed it on mt7986 or it was documenting something already in use.

Rob