[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3e27eddb-91c6-4903-9de5-f3df8098a38c@lunn.ch>
Date: Sun, 6 Oct 2024 23:32:00 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Sky Huang <SkyLake.Huang@...iatek.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Daniel Golle <daniel@...rotopia.org>,
Qingfang Deng <dqfext@...il.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org,
Steven Liu <Steven.Liu@...iatek.com>
Subject: Re: [PATCH net-next 6/9] net: phy: mediatek: Hook LED helper
functions in mtk-ge.c
> +static int mt753x_phy_led_blink_set(struct phy_device *phydev, u8 index,
> + unsigned long *delay_on,
> + unsigned long *delay_off)
> +{
> + struct mtk_gephy_priv *priv = phydev->priv;
> + bool blinking = false;
> + int err = 0;
There is no need to set err.
> +
> + err = mtk_phy_led_num_dly_cfg(index, delay_on, delay_off, &blinking);
> + if (err < 0)
> + return err;
Andrew
---
pw-bot: cr
Powered by blists - more mailing lists