linux-kernel - Re: [PATCH v5.10] xfs: add bounds checking to xlog_recover_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACzhbgR+EZ-zaRxwUZRLkQ_+9kxy_nttNyu9m9EKa12-XcOogA@mail.gmail.com>
Date: Mon, 7 Oct 2024 13:53:15 -0700
From: Leah Rumancik <leah.rumancik@...il.com>
To: Kuntal Nayak <kuntal.nayak@...adcom.com>
Cc: Greg KH <gregkh@...uxfoundation.org>, linux-xfs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, ajay.kaher@...adcom.com, 
	alexey.makhalov@...adcom.com, vasavi.sirnapalli@...adcom.com, 
	lei lu <llfamsec@...il.com>, Dave Chinner <dchinner@...hat.com>, 
	"Darrick J . Wong" <djwong@...nel.org>, Chandan Babu R <chandanbabu@...nel.org>, 
	Amir Goldstein <amir73il@...il.com>
Subject: Re: [PATCH v5.10] xfs: add bounds checking to xlog_recover_process_data

Hi Kuntal!

Thanks for proposing these patches. The current process for
backporting to xfs requires that patches are tested for any
regressions via xfstests. I believe Amir was last in charge of 5.10.y.
I think he is still on vacation, but even once he returns, I'm not
sure if he will be maintaining this branch any longer so it seems
5.10.y might be left unsupported when it comes to XFS. If you'd like
to take over for 5.10.y to keep backports flowing, we'd be happy to
have you join our efforts :)

- leah

On Mon, Oct 7, 2024 at 12:48 PM Kuntal Nayak <kuntal.nayak@...adcom.com> wrote:
>
> Thank you, Greg, for getting back to me. Following is the order for patches,
>
> 1. xfs: No need for inode number error injection in __xfs_dir3_data_check
> 2. xfs: don't walk off the end of a directory data block
> 3. xfs: add bounds checking to xlog_recover_process_data
>
>
> Hello xfs-team, could you kindly assist me in reviewing the 3 patches
> listed above for LTS v5.10?
>
> ------
> Sincerely,
> Kuntal
>
> On Fri, Sep 27, 2024 at 1:00 AM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Tue, Sep 24, 2024 at 03:39:56PM -0700, Kuntal Nayak wrote:
> > > From: lei lu <llfamsec@...il.com>
> > >
> > > [ Upstream commit fb63435b7c7dc112b1ae1baea5486e0a6e27b196 ]
> >
> > Also, what is the ordering here?  Should I just guess?