linux-kernel - Re: [PATCH V3 06/11] accel/amdxdna: Add GEM buffer object management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77ad50fa-5c94-a93b-a123-48f653291f51@amd.com>
Date: Mon, 7 Oct 2024 15:35:44 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: Jeffrey Hugo <quic_jhugo@...cinc.com>, <ogabbay@...nel.org>,
	<dri-devel@...ts.freedesktop.org>
CC: <linux-kernel@...r.kernel.org>, <min.ma@....com>, <max.zhen@....com>,
	<sonal.santan@....com>, <king.tam@....com>
Subject: Re: [PATCH V3 06/11] accel/amdxdna: Add GEM buffer object management


On 10/4/24 10:56, Jeffrey Hugo wrote:
> On 9/11/2024 12:05 PM, Lizhi Hou wrote:
>> +/**
>> + * struct amdxdna_drm_create_bo - Create a buffer object.
>> + * @flags: Buffer flags. MBZ.
>> + * @type: Buffer type.
>> + * @pad1: MBZ.
>> + * @vaddr: User VA of buffer if applied. MBZ.
>> + * @size: Size in bytes.
>> + * @handle: Returned DRM buffer object handle.
>> + * @pad2: MBZ.
>> + */
>> +struct amdxdna_drm_create_bo {
>> +    __u64    flags;
>> +    __u32    type;
>> +    __u32    pad1;
>> +    __u64    vaddr;
>> +    __u64    size;
>> +    __u32    handle;
>> +    __u32    pad2;
>> +};
>
> Why not eliminate both padding fields by either moving "handle" up, or 
> "type" down?

Ok. I will change this.


Thanks,

Lizhi