linux-kernel - Re: [PATCH V3 07/11] accel/amdxdna: Add command execution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d295041-fa3d-58e5-9fa7-c835f7435bb9@amd.com>
Date: Mon, 7 Oct 2024 15:51:17 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: Jeffrey Hugo <quic_jhugo@...cinc.com>, <ogabbay@...nel.org>,
	<dri-devel@...ts.freedesktop.org>
CC: <linux-kernel@...r.kernel.org>, <min.ma@....com>, <max.zhen@....com>,
	<sonal.santan@....com>, <king.tam@....com>
Subject: Re: [PATCH V3 07/11] accel/amdxdna: Add command execution


On 10/4/24 11:01, Jeffrey Hugo wrote:
> On 9/11/2024 12:06 PM, Lizhi Hou wrote:
>> +enum amdxdna_cmd_type {
>> +    AMDXDNA_CMD_SUBMIT_EXEC_BUF = 0,
>> +    AMDXDNA_CMD_SUBMIT_DEPENDENCY,
>> +    AMDXDNA_CMD_SUBMIT_SIGNAL,
>> +};
>> +
>> +/**
>> + * struct amdxdna_drm_exec_cmd - Execute command.
>> + * @ext: MBZ.
>> + * @ext_flags: MBZ.
>
> I see a check for ext_flags, but not ext

I will add the check.


Thanks,

Lizhi

>
>> + * @hwctx: Hardware context handle.
>> + * @type: One of command type in enum amdxdna_cmd_type.
>> + * @cmd_handles: Array of command handles or the command handle itself
>> + *               in case of just one.
>> + * @args: Array of arguments for all command handles.
>> + * @cmd_count: Number of command handles in the cmd_handles array.
>> + * @arg_count: Number of arguments in the args array.
>> + * @seq: Returned sequence number for this command.
>> + */
>> +struct amdxdna_drm_exec_cmd {
>> +    __u64 ext;
>> +    __u64 ext_flags;
>> +    __u32 hwctx;
>> +    __u32 type;
>> +    __u64 cmd_handles;
>> +    __u64 args;
>> +    __u32 cmd_count;
>> +    __u32 arg_count;
>> +    __u64 seq;
>> +};