linux-kernel - Re: [PATCH] sched: Fix typo of head comment of ___update_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtD7TPYcPcwHxC_n8PObZMgqxU+9=U-F6yJbP0=cLAB8hQ@mail.gmail.com>
Date: Mon, 7 Oct 2024 08:42:14 +0200
From: Vincent Guittot <vincent.guittot@...aro.org>
To: Zhouyi Zhou <zhouzhouyi@...il.com>
Cc: linux-kernel@...r.kernel.org, mingo@...hat.com, peterz@...radead.org, 
	juri.lelli@...hat.com, dietmar.eggemann@....com, rostedt@...dmis.org, 
	bsegall@...gle.com, mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com
Subject: Re: [PATCH] sched: Fix typo of head comment of ___update_load_avg

On Sat, 5 Oct 2024 at 02:53, Zhouyi Zhou <zhouzhouyi@...il.com> wrote:
>
> The head comment of ___update_load_avg illustrates the principle of
> PELT divider. "unwanted oscillation in the range [1002..1024[" should
> be "unwanted oscillation in the range [1002..1024]".
>
> Fix above typo.

This is not a typo as 1024 is an excluded endpoint of the interval.
Some may use [1002..1024) but both [1002..1024[ and [1002..1024) can
be used

>
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@...il.com>
> ---
>  kernel/sched/pelt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/pelt.c b/kernel/sched/pelt.c
> index a9c65d97b3ca..565171fb2138 100644
> --- a/kernel/sched/pelt.c
> +++ b/kernel/sched/pelt.c
> @@ -233,7 +233,7 @@ ___update_load_sum(u64 now, struct sched_avg *sa,
>   * When syncing *_avg with *_sum, we must take into account the current
>   * position in the PELT segment otherwise the remaining part of the segment
>   * will be considered as idle time whereas it's not yet elapsed and this will
> - * generate unwanted oscillation in the range [1002..1024[.
> + * generate unwanted oscillation in the range [1002..1024].
>   *
>   * The max value of *_sum varies with the position in the time segment and is
>   * equals to :
> --
> 2.34.1
>