linux-kernel - Re: [PATCH] sched/deadline: Use hrtick_enabled_dl() before start_hrtick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZwOJ781mpF137oT2@jlelli-thinkpadt14gen4.remote.csb>
Date: Mon, 7 Oct 2024 08:12:47 +0100
From: Juri Lelli <juri.lelli@...hat.com>
To: Phil Auld <pauld@...hat.com>
Cc: linux-kernel@...r.kernel.org, Valentin Schneider <vschneid@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] sched/deadline: Use hrtick_enabled_dl() before
 start_hrtick_dl()

Hi Phil,

On 04/10/24 08:37, Phil Auld wrote:
> The deadline server code moved one of the start_hrtick_dl() calls
> but dropped the dl specific hrtick_enabled check. This causes hrticks
> to get armed even when sched_feat(HRTICK_DL) is false. Fix it.
> 
> Fixes: 63ba8422f876 ("sched/deadline: Introduce deadline servers")
> Signed-off-by: Phil Auld <pauld@...hat.com>
> Cc: Juri Lelli <juri.lelli@...hat.com>
> Cc: Valentin Schneider <vschneid@...hat.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Dietmar Eggemann <dietmar.eggemann@....com>
> Cc: Steven Rostedt <rostedt@...dmis.org>

Indeed. Good catch!

Acked-by: Juri Lelli <juri.lelli@...hat.com>

Best,
Juri