linux-kernel - [tip: sched/urgent] sched/deadline: Use hrtick_enabled_dl() before start_hrtick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172874256158.1442.10862855848728117458.tip-bot2@tip-bot2>
Date: Sat, 12 Oct 2024 14:16:01 -0000
From: "tip-bot2 for Phil Auld" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Phil Auld <pauld@...hat.com>,
 "Peter Zijlstra (Intel)" <peterz@...radead.org>,
 Juri Lelli <juri.lelli@...hat.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Subject: [tip: sched/urgent] sched/deadline: Use hrtick_enabled_dl() before
 start_hrtick_dl()

The following commit has been merged into the sched/urgent branch of tip:

Commit-ID:     d16b7eb6f523eeac3cff13001ef2a59cd462aa73
Gitweb:        https://git.kernel.org/tip/d16b7eb6f523eeac3cff13001ef2a59cd462aa73
Author:        Phil Auld <pauld@...hat.com>
AuthorDate:    Fri, 04 Oct 2024 08:37:29 -04:00
Committer:     Peter Zijlstra <peterz@...radead.org>
CommitterDate: Fri, 11 Oct 2024 10:49:32 +02:00

sched/deadline: Use hrtick_enabled_dl() before start_hrtick_dl()

The deadline server code moved one of the start_hrtick_dl() calls
but dropped the dl specific hrtick_enabled check. This causes hrticks
to get armed even when sched_feat(HRTICK_DL) is false. Fix it.

Fixes: 63ba8422f876 ("sched/deadline: Introduce deadline servers")
Signed-off-by: Phil Auld <pauld@...hat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
Acked-by: Juri Lelli <juri.lelli@...hat.com>
Link: https://lore.kernel.org/r/20241004123729.460668-1-pauld@redhat.com
---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 9ce93d0..be1b917 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -2385,7 +2385,7 @@ static void set_next_task_dl(struct rq *rq, struct task_struct *p, bool first)
 
 	deadline_queue_push_tasks(rq);
 
-	if (hrtick_enabled(rq))
+	if (hrtick_enabled_dl(rq))
 		start_hrtick_dl(rq, &p->dl);
 }