linux-kernel - Re: [PATCH] sched: Fix typo of head comment of ___update_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKfTPtCKEi6-nW5sQ1y2B9zwgmqtEyesooZ62cm=+37AoEPFHw@mail.gmail.com>
Date: Mon, 7 Oct 2024 10:15:54 +0200
From: Vincent Guittot <vincent.guittot@...aro.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Zhouyi Zhou <zhouzhouyi@...il.com>, linux-kernel@...r.kernel.org, mingo@...hat.com, 
	juri.lelli@...hat.com, dietmar.eggemann@....com, rostedt@...dmis.org, 
	bsegall@...gle.com, mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com
Subject: Re: [PATCH] sched: Fix typo of head comment of ___update_load_avg

On Mon, 7 Oct 2024 at 10:10, Peter Zijlstra <peterz@...radead.org> wrote:
>
> On Mon, Oct 07, 2024 at 08:42:14AM +0200, Vincent Guittot wrote:
> > On Sat, 5 Oct 2024 at 02:53, Zhouyi Zhou <zhouzhouyi@...il.com> wrote:
> > >
> > > The head comment of ___update_load_avg illustrates the principle of
> > > PELT divider. "unwanted oscillation in the range [1002..1024[" should
> > > be "unwanted oscillation in the range [1002..1024]".
> > >
> > > Fix above typo.
> >
> > This is not a typo as 1024 is an excluded endpoint of the interval.
> > Some may use [1002..1024) but both [1002..1024[ and [1002..1024) can
> > be used
>
> Because I'm weird, I googled this, and the [a,b[ notation is from
> Bourbaki and hence popular in the French speaking world :-)

Yeah, I firstly thought reversed square bracket was only french and
parenthesis was the international one but the International standard
ISO 31-11 describes both in fact

>
> We don't have many intervals specified in comments and hence we can't
> make the inconsistent style argument either.
>
> So yeah, let it be.. at best its a trigger to get people to better look
> at the code. At worst its one of those triggers that people keep trying
> to mindlessly 'fix', like my use of borken :-)