linux-kernel - Re: [PATCH] arm64: dts: mediatek: mt8390-genio-700-evk: enable pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27719ca0-7794-44db-b8dd-9a31c726ee6d@gmail.com>
Date: Mon, 7 Oct 2024 16:08:48 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: Macpaul Lin <macpaul.lin@...iatek.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Jieyy Yang <jieyy.yang@...iatek.com>, Jian Yang <jian.yang@...iatek.com>,
 Jianguo Zhang <jianguo.zhang@...iatek.com>,
 Alexandre Mergnat <amergnat@...libre.com>
Cc: Bear Wang <bear.wang@...iatek.com>, Pablo Sun <pablo.sun@...iatek.com>,
 Macpaul Lin <macpaul@...il.com>, Sen Chu <sen.chu@...iatek.com>,
 Chris-qj chen <chris-qj.chen@...iatek.com>,
 MediaTek Chromebook Upstream
 <Project_Global_Chrome_Upstream_Group@...iatek.com>,
 Chen-Yu Tsai <wenst@...omium.org>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8390-genio-700-evk: enable pcie



On 07/10/2024 12:07, Macpaul Lin wrote:
> Enable PCIE, PCIEPHY and related Pinctrls for mt8390-genio-700-evk
> board.
> 
> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> ---
>   .../dts/mediatek/mt8390-genio-700-evk.dts     | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> Changes for v1:
>   - This patch depends on the pcie patch of mt8188.dtsi
>     [1] https://lore.kernel.org/all/20241004081218.55962-3-fshao@chromium.org/
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts b/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts
> index 3e77f59f2c74..bb68665f0b2d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts
> @@ -393,6 +393,16 @@ &mt6359codec {
>   	mediatek,mic-type-1 = <3>; /* DCC */
>   };
>   
> +&pcie {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pcie_pins_default>;
> +	status = "okay";
> +};
> +
> +&pciephy {
> +	status = "okay";
> +};
> +
>   &pio {
>   	audio_default_pins: audio-default-pins {
>   		pins-cmd-dat {
> @@ -758,6 +768,15 @@ pins-rst {
>   		};
>   	};
>   
> +	pcie_pins_default: pcie-default {
> +		mux {
> +			pinmux = <PINMUX_GPIO47__FUNC_I1_WAKEN>,
> +				 <PINMUX_GPIO48__FUNC_O_PERSTN>,
> +				 <PINMUX_GPIO49__FUNC_B1_CLKREQN>;
> +			bias-pull-up;
> +		};
> +	};
> +
>   	rt1715_int_pins: rt1715-int-pins {
>   		pins_cmd0_dat {
>   			pinmux = <PINMUX_GPIO12__FUNC_B_GPIO12>;