linux-kernel - Re: [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172839929004.1375659.17484732521935836404.robh@kernel.org>
Date: Tue, 08 Oct 2024 09:56:40 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Joel Selvaraj <foss@...lselvaraj.com>
Cc: linux-arm-msm@...r.kernel.org, Konrad Dybcio <konradybcio@...nel.org>, 
 Bjorn Andersson <andersson@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org, 
 Joel Selvaraj <jo@...amily.in>, linux-kernel@...r.kernel.org, 
 Joel Selvaraj <joelselvaraj.oss@...il.com>
Subject: Re: [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support


On Mon, 07 Oct 2024 21:59:25 -0500, Joel Selvaraj wrote:
> In the first patch, I have enabled the  qupv3_id_1 and gpi_dma1 as they
> are required for configuring touchscreen. Also added the pinctrl configurations.
> These are common for both the Poco F1 Tianma and EBBG panel variant.
> 
> In the subsequent patches, I have enabled support for the Novatek NT36672a
> touchscreen and FocalTech FT8719 touchscreen that are used in the Poco F1
> Tianma and EBBG panel variant respectively.
> 
> Signed-off-by: Joel Selvaraj <foss@...lselvaraj.com>
> ---
> Joel Selvaraj (3):
>       arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes
>       arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: introduce touchscreen support
>       arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce touchscreen support
> 
>  .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi   | 39 ++++++++++++++++++++++
>  .../boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts | 23 +++++++++++++
>  .../dts/qcom/sdm845-xiaomi-beryllium-tianma.dts    | 23 +++++++++++++
>  3 files changed, 85 insertions(+)
> ---
> base-commit: d435d1e92be5fd26cd383fbddb596942ddc52b9f
> change-id: 20241007-pocof1-touchscreen-support-c752a162cdc2
> 
> Best regards,
> --
> Joel Selvaraj <foss@...lselvaraj.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/sdm845-xiaomi-beryllium-ebbg.dtb qcom/sdm845-xiaomi-beryllium-tianma.dtb' for 20241007-pocof1-touchscreen-support-v1-0-db31b21818c5@...lselvaraj.com:

arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: touchscreen@38: 'panel' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/input/touchscreen/edt-ft5x06.yaml#
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dtb: pinctrl@...0000: ts-int-default-state: 'oneOf' conditional failed, one must be fixed:
	'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	False schema does not allow True
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dtb: pinctrl@...0000: ts-int-sleep-state: 'oneOf' conditional failed, one must be fixed:
	'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	False schema does not allow True
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: pinctrl@...0000: ts-int-default-state: 'oneOf' conditional failed, one must be fixed:
	'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	False schema does not allow True
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: pinctrl@...0000: ts-int-sleep-state: 'oneOf' conditional failed, one must be fixed:
	'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	False schema does not allow True
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#