linux-kernel - Re: [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07f712be-e30b-40e9-ac64-5fd8a26b145c@oss.qualcomm.com>
Date: Sat, 26 Oct 2024 12:27:45 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: "Rob Herring (Arm)" <robh@...nel.org>,
        Joel Selvaraj <foss@...lselvaraj.com>
Cc: linux-arm-msm@...r.kernel.org, Konrad Dybcio <konradybcio@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org,
        Joel Selvaraj <jo@...amily.in>, linux-kernel@...r.kernel.org,
        Joel Selvaraj <joelselvaraj.oss@...il.com>
Subject: Re: [PATCH 0/3] Add Xiaomi Poco F1 touchscreen support

On 8.10.2024 4:56 PM, Rob Herring (Arm) wrote:
> 
> On Mon, 07 Oct 2024 21:59:25 -0500, Joel Selvaraj wrote:
>> In the first patch, I have enabled the  qupv3_id_1 and gpi_dma1 as they
>> are required for configuring touchscreen. Also added the pinctrl configurations.
>> These are common for both the Poco F1 Tianma and EBBG panel variant.
>>
>> In the subsequent patches, I have enabled support for the Novatek NT36672a
>> touchscreen and FocalTech FT8719 touchscreen that are used in the Poco F1
>> Tianma and EBBG panel variant respectively.
>>
>> Signed-off-by: Joel Selvaraj <foss@...lselvaraj.com>
>> ---

[...]


> New warnings running 'make CHECK_DTBS=y qcom/sdm845-xiaomi-beryllium-ebbg.dtb qcom/sdm845-xiaomi-beryllium-tianma.dtb' for 20241007-pocof1-touchscreen-support-v1-0-db31b21818c5@...lselvaraj.com:
> 
> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: touchscreen@38: 'panel' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/input/touchscreen/edt-ft5x06.yaml#

This needs a bindings update

> arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dtb: pinctrl@...0000: ts-int-default-state: 'oneOf' conditional failed, one must be fixed:
> 	'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
> 	False schema does not allow True
> 	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml#

I think these warnings are unhappy about input-enable (which is not really a
thing on TLMM, see:

e49eabe3e13f ("pinctrl: qcom: Support OUTPUT_ENABLE; deprecate INPUT_ENABLE")

Konrad