linux-kernel - Re: [PATCH v8 8/8] clk: Add KUnit tests for clks registered with struct clk_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <594e8e50-8322-480e-ae34-3f8e14f3fe18@roeck-us.net>
Date: Tue, 8 Oct 2024 16:27:37 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Stephen Boyd <sboyd@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>
Cc: Michael Turquette <mturquette@...libre.com>,
 linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
 patches@...ts.linux.dev, kunit-dev@...glegroups.com,
 linux-kselftest@...r.kernel.org, devicetree@...r.kernel.org,
 Brendan Higgins <brendan.higgins@...ux.dev>, David Gow
 <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J.Wysocki" <rafael@...nel.org>, Rob Herring <robh@...nel.org>,
 Saravana Kannan <saravanak@...gle.com>, Daniel Latypov
 <dlatypov@...gle.com>, Christian Marangi <ansuelsmth@...il.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Maxime Ripard <maxime@...no.tech>,
 Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH v8 8/8] clk: Add KUnit tests for clks registered with
 struct clk_parent_data

On 10/8/24 16:12, Stephen Boyd wrote:
> Quoting Guenter Roeck (2024-10-03 21:52:09)
>> On 10/3/24 17:42, Stephen Boyd wrote:
>>>
>>> Can you please describe how you run the kunit test? And provide the qemu
>>> command you run to boot arm64 with acpi?
>>>
>>
>> Example command line:
>>
>> qemu-system-aarch64 -M virt -m 512 \
>>        -kernel arch/arm64/boot/Image -no-reboot -nographic \
>>        -snapshot \
>>        -bios /opt/buildbot/rootfs/arm64/../firmware/QEMU_EFI-aarch64.fd \
>>        -device virtio-blk-device,drive=d0 \
>>        -drive file=rootfs.ext2,if=none,id=d0,format=raw \
>>        -cpu cortex-a57 -serial stdio -monitor none -no-reboot \
>>        --append "kunit.stats_enabled=2 kunit.filter=speed>slow root=/dev/vda rootwait earlycon=pl011,0x9000000 console=ttyAMA0"
>>
>> That works fine for me. Configuration is arm64 defconfig plus various
>> debug and kunit options. I built the efi image myself from sources.
>> The root file system is from buildroot with modified init script.
>> kunit tests are all built into the kernel and run during boot.
> 
> Thanks. I figured out that I was missing enabling CONFIG_ACPI. Here's my
> commandline
> 
> ./tools/testing/kunit/kunit.py run --arch=arm64 \
> 	--kunitconfig=drivers/of \
> 	--qemu_args="-bios /usr/share/qemu-efi-aarch64/QEMU_EFI.fd -smp 2" \
> 	--kconfig_add="CONFIG_ACPI=y" \
> 	--kernel_args="earlycon=pl011,0x9000000"
> 
> Now I can boot and reproduce the failure, but there's another problem.
> ACPI disables itself when it fails to find tables.
> 
>   ACPI: Unable to load the System Description Tables
> 
> This calls disable_acpi() which sets acpi_disabled to 1. This happens
> before the unit test runs, meaning we can't reliably use 'acpi_disabled'
> as a method to skip.
> 
> The best I can come up with then is to test for a NULL of_root when
> CONFIG_ARM64 and CONFIG_ACPI are enabled, because the tests
> intentionally don't work when both those configs are enabled and the
> 'of_root' isn't populated. In all other cases the 'of_root' missing is a
> bug. I'll probably make this into some sort of kunit helper function in
> of_private.h and send it to DT maintainers.

Sounds good. Thanks a lot for tracking this down.

That makes me wonder though why only arm64 has that restriction. Both
riscv and loongarch have ACPI enabled in their defconfig files but call
unflatten_device_tree() unconditionally.

Oh well ...

Thanks,
Guenter