linux-kernel - Re: [PATCH v8 8/8] clk: Add KUnit tests for clks registered with struct clk_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81668a9199b39fe46cefd256d3eac44c.sboyd@kernel.org>
Date: Wed, 09 Oct 2024 12:07:09 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>, Shuah Khan <skhan@...uxfoundation.org>
Cc: Michael Turquette <mturquette@...libre.com>, linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, patches@...ts.linux.dev, kunit-dev@...glegroups.com, linux-kselftest@...r.kernel.org, devicetree@...r.kernel.org, Brendan Higgins <brendan.higgins@...ux.dev>, David Gow <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Rafael J.Wysocki <rafael@...nel.org>, Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>, Daniel Latypov <dlatypov@...gle.com>, Christian Marangi <ansuelsmth@...il.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Maxime Ripard <maxime@...no.tech>, Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH v8 8/8] clk: Add KUnit tests for clks registered with struct clk_parent_data

Quoting Guenter Roeck (2024-10-08 16:27:37)
> On 10/8/24 16:12, Stephen Boyd wrote:
> > 
> > The best I can come up with then is to test for a NULL of_root when
> > CONFIG_ARM64 and CONFIG_ACPI are enabled, because the tests
> > intentionally don't work when both those configs are enabled and the
> > 'of_root' isn't populated. In all other cases the 'of_root' missing is a
> > bug. I'll probably make this into some sort of kunit helper function in
> > of_private.h and send it to DT maintainers.
> 
> Sounds good. Thanks a lot for tracking this down.
> 
> That makes me wonder though why only arm64 has that restriction. Both
> riscv and loongarch have ACPI enabled in their defconfig files but call
> unflatten_device_tree() unconditionally.
> 
> Oh well ...

Some of the reason is described in the thread I linked earlier. In
particular, this email from Mark[1]. There's also more comments from
Mark on an earlier patchset[2]. Maybe arm64 will allow it later, and
then we'll be able to revert this skip patch.

[1] https://lore.kernel.org/all/Zd4dQpHO7em1ji67@FVFF77S0Q05N.cambridge.arm.com/
[2] https://lore.kernel.org/all/ZaZtbU9hre3YhZam@FVFF77S0Q05N/