linux-kernel - Re: [PATCH v3 0/8] tracing: Allow system call tracepoints to handle page faults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241008193326.5ec7fb10@gandalf.local.home>
Date: Tue, 8 Oct 2024 19:33:26 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, linux-kernel@...r.kernel.org,
 Peter Zijlstra <peterz@...radead.org>, Alexei Starovoitov <ast@...nel.org>,
 Yonghong Song <yhs@...com>, "Paul E . McKenney" <paulmck@...nel.org>, Ingo
 Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, Mark
 Rutland <mark.rutland@....com>, Alexander Shishkin
 <alexander.shishkin@...ux.intel.com>, Namhyung Kim <namhyung@...nel.org>,
 Andrii Nakryiko <andrii.nakryiko@...il.com>, bpf@...r.kernel.org, Joel
 Fernandes <joel@...lfernandes.org>, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/8] tracing: Allow system call tracepoints to handle
 page faults

On Fri,  4 Oct 2024 10:58:10 -0400
Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:

> Wire up the system call tracepoints with Tasks Trace RCU to allow
> the ftrace, perf, and eBPF tracers to handle page faults.

Hi Mathieu,

Looks good besides the little nits I mentioned.

Could you fix them up and rebase on top of:

  git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git

  branch: trace/core

The biggest difference is that I added Josh's patch to not use the obsolete
static_key_false() anymore. I fixed up your patch before applying it by
basically just doing a:

  s/static_key_false/static_branch_unlikely/

And then removing the extra tabs at the end. That allowed it to apply
without more tweaks.

If you can send a v4 with those updates, I'll apply it and start testing it.

-- Steve